Repository navigation
Conversation
# Conflicts: # .changeset/shorter-wait-for.md # packages/agent-core-v2/src/agent/tools/task/task-wait/taskWaitTool.ts
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cdc8ba7b18
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
中文版
需求或 Bug
基于 #4085。为
Monitor工具补充在真实 TUI 中运行的端到端测试。复用 #4069 的 tmux 测试框架;在 #4069 合并前,本 PR 的 diff 也包含那两个文件,#4069 合并后会同步main,diff 只剩本 PR 自己的改动。Bug 复现步骤
N/A
根本原因
N/A
代码变更
apps/kimi-code/test/e2e/ ~├── tui-sandbox.ts # 新增 monitor(可带 timeout / persistent)、foreground、stopMonitor、 ~│ # waitForMonitor、monitorOutput 步骤;运行时按描述查找 monitor 的 task id; ~│ # startFakeService(模拟远程服务);scenario 可传环境变量, ~│ # 上下文提供 workDir 和 relaunch(用 --continue 重启同一会话) +└── tui-monitor.e2e.test.ts # 16 个 Monitor 场景场景(通过
KIMI_CODE_EXPERIMENTAL_MONITOR=1打开开关):<event omitted="10">,TUI 显示省略数,TaskOutput 能读到完整日志</event></notification>…、&、超长行)只作为数据出现在事件中--continue恢复会话后回放事件行且不会自动开始新轮次行为变化与受影响用户
无——只有测试。与现有 e2e 一样需要主动开启:只在设置
KIMI_E2E=1且 PATH 中有tmux时运行,否则跳过,默认的vitest和 CI 不受影响。KIMI_E2E=1 pnpm --filter @moonshot-ai/kimi-code exec vitest run test/e2e/tui-monitor.e2e.test.tsRequirement or Bug
Stacked on #4085. Adds end-to-end tests that drive the real TUI for the
Monitortool. It reuses the tmux harness from #4069; until #4069 merges, this PR's diff also contains those two files. Once #4069 lands,mainwill be merged in and the diff will shrink to this PR's own changes.Bug Reproduction Steps
N/A
Root Cause
N/A
Code Changes
apps/kimi-code/test/e2e/ ~├── tui-sandbox.ts # adds monitor (with timeout / persistent), foreground, stopMonitor, ~│ # waitForMonitor and monitorOutput steps; a monitor's task id is looked up ~│ # by description at run time; startFakeService (a stand-in remote service); ~│ # scenario takes env vars, and its context has workDir and relaunch ~│ # (restart into the same session with --continue) +└── tui-monitor.e2e.test.ts # 16 Monitor scenariosScenarios (the flag is turned on with
KIMI_CODE_EXPERIMENTAL_MONITOR=1):<event omitted="10">, the TUI shows the omitted count, and TaskOutput has the full log</event></notification>…,&, an overlong line) appear only as data inside the eventtimeouta monitor sends one notice and its process is killed; it can then be re-armed withpersistent--continuereplays the event rows and starts no new turnBehavior Changes and Affected Users
None — tests only. The suite is opt-in like the existing e2e tests: it runs only with
KIMI_E2E=1andtmuxon PATH, and skips otherwise, so defaultvitestruns and CI are unchanged.KIMI_E2E=1 pnpm --filter @moonshot-ai/kimi-code exec vitest run test/e2e/tui-monitor.e2e.test.tsChecklist
/approve).gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.